Skip to content

add proper syntax highlighting for returned data#624

Draft
erwindon wants to merge 1 commit intomasterfrom
highlightjs
Draft

add proper syntax highlighting for returned data#624
erwindon wants to merge 1 commit intomasterfrom
highlightjs

Conversation

@erwindon
Copy link
Copy Markdown
Owner

@erwindon erwindon commented Aug 11, 2024

Is your feature request related to a problem? Please describe.
SaltGui shows (structured) results in a plain way. A few low-level formatting tricks are use to format it.

Describe the solution you'd like
Use library that can do syntax highlighting on data.

Additional context

  • library must be free to use
  • library must be simple to use
  • library must be small (as shipped)

@erwindon
Copy link
Copy Markdown
Owner Author

erwindon commented Aug 11, 2024

use https://highlightjs.org/
download a bundle with only json and yaml (nested will use yaml)

Comment thread saltgui/static/highlight/es/languages/javascript.js Fixed
Comment thread saltgui/static/highlight/es/languages/typescript.js Fixed
@erwindon erwindon force-pushed the highlightjs branch 6 times, most recently from 7e26fb1 to 84fa546 Compare August 11, 2024 18:27
@erwindon erwindon force-pushed the highlightjs branch 4 times, most recently from 9a05080 to 271ebac Compare October 25, 2024 18:51
Repository owner deleted a comment from sonarqubecloud bot Oct 25, 2024
@erwindon erwindon marked this pull request as ready for review October 25, 2024 19:01
@erwindon erwindon force-pushed the highlightjs branch 5 times, most recently from 6ef0104 to 914f76a Compare November 2, 2024 22:45
@erwindon erwindon force-pushed the highlightjs branch 2 times, most recently from 991a407 to f1597b7 Compare September 3, 2025 13:07
@erwindon erwindon force-pushed the highlightjs branch 2 times, most recently from 2495ee8 to d714e9d Compare November 23, 2025 12:30
@erwindon erwindon marked this pull request as draft April 17, 2026 08:37
@erwindon erwindon force-pushed the highlightjs branch 4 times, most recently from 860c07e to 4fb800a Compare April 18, 2026 21:09
Repository owner deleted a comment from sonarqubecloud bot Apr 18, 2026
Repository owner deleted a comment from sonarqubecloud bot Apr 18, 2026
Repository owner deleted a comment from sonarqubecloud bot Apr 18, 2026
Repository owner deleted a comment from sonarqubecloud bot Apr 18, 2026
Repository owner deleted a comment from sonarqubecloud bot Apr 18, 2026
@erwindon erwindon marked this pull request as ready for review April 18, 2026 21:19
@erwindon erwindon marked this pull request as draft April 18, 2026 21:19
@erwindon erwindon force-pushed the highlightjs branch 3 times, most recently from 3b7a9ea to 9dc9ef0 Compare April 18, 2026 22:24
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants